Draft
Conversation
This was referenced Nov 4, 2024
Merged
YO4
force-pushed
the
new_yamatanooroti_for_win
branch
from
5ab50e3 to
f7d6b24
Compare
…BCS chars test_yamatanooroti: change console condepage on legacy conhost even if only display DBCS characters (no input DBCS) omit if changing codepage failed writing DBCS characters to legacy console displays '?' character. confirmed on Windows 11 dev VM (that has no codepage 932 on legacy mode enabled conhost)
omit if changing codepage failed because of console input (using ansi codepage) that has coderange out of console codepage is useless
Non VT sequence supporting windows console has forced newline output when writing rightmost column of line. This may appear as an additional line break. Clearing screen to avoid this environment dependent behavior.
YO4
force-pushed
the
new_yamatanooroti_for_win
branch
from
f7d6b24 to
b383a37
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is part of supporting windows for reline CI using yamatanooroti.
This PR follows PR#775.
This PR contains the following test_yamatanooroti changes.
The merge requires finalizing api changes to the code page settings on the yamatanooroti side.